Update Landing Zone deployment guide with a workaround for yet another Terraform import bug #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
requested review from
eak12913,
josh-padnick,
oredavids and
tsmit291
as code owners
brikis98
commented
Oct 15, 2020
| @@ -1462,12 +1462,7 @@ The example code above does the following: | |||
|
|
|||
| . **Create IAM users**. For this example, we create `alice` and `bob`, and carol, adding `alice` to the `full-access` | |||
| IAM group and `carol` to the `billing` IAM group. _Note_: your own IAM user (the one you created manually) should be | |||
| in the `users` list, and you should be able to manage it with Terraform by running the `import` command, but due to | |||
There was a problem hiding this comment.
I forgot to clean this up in the previous PR.
|
Deploy preview for keen-clarke-470db9 ready! Built with commit fb11dd0 |
brikis98
changed the title
ina-stoyanova
approved these changes
Oct 15, 2020
|
Thanks for the review! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/gruntwork-io/module-security/issues/358, I found yet another bug with the
importcommand in Terraform, introduced as part of the 0.13.x upgrade. In gruntwork-io/terragrunt#1391, I'm updating Terragrunt to support working around this bug. In this PR, I'm updating our docs to use the features of the updated Terragrunt to work around this issue.Direct link for easier reading.